-
-
Notifications
You must be signed in to change notification settings - Fork 612
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0][MIG] mail_notification_custom_subject #1454
[16.0][MIG] mail_notification_custom_subject #1454
Conversation
…l notifications This module allows you to specify templates to override the subject on the notification emails sent by Odoo. TT27191 Co-authored-by: Pedro M. Baeza <pedro.baeza@tecnativa.com>
…ad_template_does_not_break test
[UPD] README.rst
[IMP] update dotfiles [ci skip]
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: social-15.0/social-15.0-mail_notification_custom_subject Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_notification_custom_subject/
… send messages After installing the module, any user was required to have admin rights to be able to search across models. This fix does just that search with sudo and returns back to non-sudo mode immediately after. This way, we don't need to increase permissions for everybody. Tests now run unprivileged, to assert this problem never happens again. @moduon MT-1644 MT-1645
…n selecting subtype_id
…ert syntaxis of jinja2 to jinja3
Currently translated at 100.0% (21 of 21 strings) Translation: social-15.0/social-15.0-mail_notification_custom_subject Translate-URL: https://translation.odoo-community.org/projects/social-15-0/social-15-0-mail_notification_custom_subject/es/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please split the pre-commit changes from the migration itself as stated in the migration guide
/ocabot migration mail_notification_custom_subject
6bdb165
to
b39e093
Compare
@pedrobaeza done! Can you revise again please? Thank you! |
OK, more or less, although the README changes should happen in the migration one, but let's not block more: /ocabot merge nobump |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at 47ec998. Thanks a lot for contributing to OCA. ❤️ |
Standard migration to v16.
@moduon MT-7401
@Shide @yajo @EmilioPascual @rafaelbn please review, if you can.